Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cloud fraction callback before rrtmgp #2764

Merged
merged 1 commit into from
Mar 7, 2024
Merged

move cloud fraction callback before rrtmgp #2764

merged 1 commit into from
Mar 7, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Mar 7, 2024

Purpose

This is at least one of the reasons that the all-sky radiation job is non-deterministic. Part of #2721. Also increases jet nfailures.

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member Author

szy21 commented Mar 7, 2024

@charleskawczynski I think this should fix the non-deterministic issue, and I checked locally that the job is reproducible by looking at the norm of the solution. But is there an easy way to make sure the regression test works before merging it?

Edit: Actually it is still non-deterministic in some cases, which I think might be related to an issue in RRTMGP. I won't add back the regression test in this PR, but we should still have cloud fraction callback before rrtmgp I think.

@charleskawczynski
Copy link
Member

Good catch! I'm not sure why this would result in new JET failures, though

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that!

@charleskawczynski
Copy link
Member

Feel free to increase the number of allowed JET failures, so that we can merge this @szy21!

@szy21
Copy link
Member Author

szy21 commented Mar 7, 2024

Sounds good, thanks. I will rebase and merge it now.

@szy21 szy21 enabled auto-merge March 7, 2024 21:45
@szy21 szy21 added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit ebf977e Mar 7, 2024
11 checks passed
@szy21 szy21 deleted the zs/hotfix branch March 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants