Reduce allocations in NetCDF writer #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
changed the title
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
2 times, most recently
from
cc99636 to
a813cb0
Compare
charleskawczynski
approved these changes
Mar 8, 2024
|
(This barely changed the allocations, as most of them are in NCDataset.) |
Sbozzolo
force-pushed
the
gb/diagnostics_ready
branch
from
53a29e3 to
1169bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time
write_fieldis called for a NetCDF writer, the code would allocate small vectors containing the desired target dimension. Once the file is written the first time, such vectors were only used to ensure that the target file contains consistent information. This PR moves this check one at higher level, removing the need to allocate the vectors.The function that is allocating is
target_coordinates, that now is called only when writing the file the first time.This PR also fixed an unrelated import error.