Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mass flux divergence to detrainment #2779

Merged
merged 1 commit into from
Mar 14, 2024
Merged

add mass flux divergence to detrainment #2779

merged 1 commit into from
Mar 14, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Mar 11, 2024

Purpose

Adds a term for mass flux divergence in detrainment. This is not implemented for diagnostic edmf as calculating the mass flux divergence at level k requires mass flux at level k, which we don't have when solving edmf variable at level k. We can get around it by using levels k-1 and k-2 to calculate the divergence, but it's a bit more complicated and we are not focusing on improving diagnostic EDMF now.

I keep both vert_div and massflux_vert_div term, to have no behavior change for diagnostic edmf. We can reevaluate later if vert_div is still needed. I also remove GeneralizedHarmonicsEntrainment and GeneralizedHarmonicsDetrainment, as it's unlikely we will use them.

part of #2705

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/detr_closure branch 4 times, most recently from b77ac2a to 44d0513 Compare March 12, 2024 21:41
post_processing/ci_plots.jl Outdated Show resolved Hide resolved
@szy21 szy21 force-pushed the zs/detr_closure branch from 44d0513 to 1c936bb Compare March 12, 2024 22:18
@szy21 szy21 marked this pull request as ready for review March 12, 2024 22:24
@szy21
Copy link
Member Author

szy21 commented Mar 12, 2024

I will update ClimaParams for other environment as well. - done

@szy21 szy21 force-pushed the zs/detr_closure branch from 1c936bb to cfc65ed Compare March 12, 2024 22:41
@szy21 szy21 requested a review from trontrytel March 12, 2024 22:55
@szy21 szy21 force-pushed the zs/detr_closure branch 2 times, most recently from db8971d to f1233d9 Compare March 13, 2024 21:50
@szy21 szy21 enabled auto-merge March 13, 2024 21:50
@szy21 szy21 added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@szy21 szy21 force-pushed the zs/detr_closure branch from f1233d9 to cba48eb Compare March 14, 2024 06:06
@szy21 szy21 enabled auto-merge March 14, 2024 06:06
@szy21 szy21 added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit a9cd8bf Mar 14, 2024
10 of 11 checks passed
@szy21 szy21 deleted the zs/detr_closure branch March 14, 2024 07:33
@szy21 szy21 linked an issue Mar 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve bomex case with explicit prognostic edmf
2 participants