add mass flux divergence to detrainment #2779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a term for mass flux divergence in detrainment. This is not implemented for diagnostic edmf as calculating the mass flux divergence at level k requires mass flux at level k, which we don't have when solving edmf variable at level k. We can get around it by using levels k-1 and k-2 to calculate the divergence, but it's a bit more complicated and we are not focusing on improving diagnostic EDMF now.
I keep both
vert_div
andmassflux_vert_div
term, to have no behavior change for diagnostic edmf. We can reevaluate later ifvert_div
is still needed. I also removeGeneralizedHarmonicsEntrainment
andGeneralizedHarmonicsDetrainment
, as it's unlikely we will use them.part of #2705
To-do
Content