Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change y axis to linear scale in ci plots #2788

Merged
merged 1 commit into from
Mar 14, 2024
Merged

change y axis to linear scale in ci plots #2788

merged 1 commit into from
Mar 14, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Mar 13, 2024

Purpose

Because this is preferred by Tapio:)

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 requested a review from Sbozzolo March 14, 2024 01:28
@szy21 szy21 marked this pull request as ready for review March 14, 2024 01:32
@szy21
Copy link
Member Author

szy21 commented Mar 14, 2024

Actually I like the previous scale for some cases. I’ll keep both options. Edit: I think linear is fine for all the cases.

@szy21 szy21 marked this pull request as draft March 14, 2024 02:04
@szy21 szy21 force-pushed the zs/plot_linear_yaxis branch from bbb12da to 2bc7f22 Compare March 14, 2024 02:06
@szy21 szy21 marked this pull request as ready for review March 14, 2024 02:07
@szy21 szy21 force-pushed the zs/plot_linear_yaxis branch from 2bc7f22 to 20ac7fc Compare March 14, 2024 02:09
@Sbozzolo
Copy link
Member

If you want linear scale, I think you can just remove the argument. That's the default.

@szy21
Copy link
Member Author

szy21 commented Mar 14, 2024

If you want linear scale, I think you can just remove the argument. That's the default.

Yeah, I kept the argument just to have more ticks. I don't care too much about it though, so I can remove it if you prefer.

@Sbozzolo
Copy link
Member

No, it's fine.

@szy21 szy21 enabled auto-merge March 14, 2024 04:30
@szy21 szy21 added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit ee2f72a Mar 14, 2024
10 of 11 checks passed
@szy21 szy21 deleted the zs/plot_linear_yaxis branch March 14, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants