Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use parameters for surface albedo #2795

Merged
merged 1 commit into from
Mar 18, 2024
Merged

use parameters for surface albedo #2795

merged 1 commit into from
Mar 18, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Mar 16, 2024 •
edited
Loading

Purpose

Use clima parameters for ocean surface albedo and water refractive index. Closes #2757

To-do

  • update ClimaParams in all environments

Content

  • I have read and checked the items on the review checklist.

@szy21 szy21 marked this pull request as ready for review March 16, 2024 21:15
@szy21 szy21 requested review from nefrathenrici and LenkaNovak and removed request for nefrathenrici March 16, 2024 21:16
@szy21 szy21 force-pushed the zs/albedo_param branch from 47fbaf7 to fe46af7 Compare March 17, 2024 03:39
LenkaNovak
LenkaNovak approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, just a minor comment on the naming.

src/parameters/Parameters.jl Outdated Show resolved Hide resolved
@szy21 szy21 added this pull request to the merge queue Mar 18, 2024
@szy21 szy21 removed this pull request from the merge queue due to a manual request Mar 18, 2024
@szy21 szy21 force-pushed the zs/albedo_param branch from fe46af7 to 0c80b08 Compare March 18, 2024 22:23
@szy21 szy21 force-pushed the zs/albedo_param branch from 0c80b08 to 843e74d Compare March 18, 2024 22:26
@szy21 szy21 enabled auto-merge March 18, 2024 22:49
@szy21 szy21 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 923f78d Mar 18, 2024
11 checks passed
@szy21 szy21 deleted the zs/albedo_param branch March 18, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nefrathenrici nefrathenrici nefrathenrici left review comments

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add refractive index to parameters
3 participants
@szy21 @LenkaNovak @nefrathenrici