Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common-spaces (SLEVE) bugfix : Constrain types. #2802

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Common-spaces (SLEVE) bugfix : Constrain types. #2802

merged 1 commit into from
Mar 18, 2024

Conversation

akshaysridhar
Copy link
Member

Constrain types.
Fixes issue where SLEVE runs don't progress past h_space construction.
modified: src/utils/common_spaces.jl
Closes #2796

Common-spaces bugfix : Use Geometry.ZPoint
7f2b402 
Constrain types.
Fixes issue where SLEVE runs don't progress past h_space construction.
	modified:   src/utils/common_spaces.jl
@akshaysridhar akshaysridhar requested a review from szy21 March 18, 2024 16:27
@akshaysridhar akshaysridhar self-assigned this Mar 18, 2024
@akshaysridhar akshaysridhar requested a review from Sbozzolo March 18, 2024 16:27
@akshaysridhar akshaysridhar changed the title Common-spaces bugfix : Constrain types. Common-spaces (SLEVE) bugfix : Constrain types. Mar 18, 2024
@akshaysridhar
Copy link
Member Author

akshaysridhar commented Mar 18, 2024 •
edited
Loading

Outcome following fix :

[ Info: Load spline
[ Info: Assign elevation
[ Info: SLEVE mesh warp
┌ Info: Resolution stats:
│   Nq = 4
│   h_elem = 16
│   z_elem = 63
│   ncols = 24576
└   ndofs_total = 1548288
[ Info: Allocating Y: 2.214 s (7758124 allocations: 487.45 MiB)
[ Info: Allocating cache (p): 39.689 s (150670995 allocations: 8.15 GiB) ...

i.e. initializes successfully.

szy21
szy21 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akshaysridhar akshaysridhar enabled auto-merge March 18, 2024 16:55
@akshaysridhar akshaysridhar added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit cc63b0b Mar 18, 2024
11 checks passed
@akshaysridhar akshaysridhar deleted the as/fix-sleve branch March 18, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees

@akshaysridhar akshaysridhar

Labels
bugfix 🐛 🔨 Long runs 🏃‍♀️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLEVE fails on GPU
3 participants
@akshaysridhar @Sbozzolo @szy21