Simplify surface function #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this breaking for the coupler? cc @LenkaNovak, @juliasloan25. If so, I'll update the news. |
Sbozzolo
approved these changes
Mar 18, 2024
no it's not, thank you for checking though! |
LenkaNovak
approved these changes
Mar 18, 2024
charleskawczynski
force-pushed
the
ck/refactor_surface
branch
from
2f90f7a to
f8221f5
Compare
charleskawczynski
force-pushed
the
ck/refactor_surface
branch
from
f8221f5 to
741eca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2800 revealed that we're not able to always inline. The first culprit we run into is
surface_state_to_conditions, which is quite complicated. This PR breaks off the temperature computation into a separate function, and passes less data to the function.This function call (to
surface_state_to_conditions) is more expensive than the call to saturation adjustment, which involves a non-linear solve. So, there is clearly a performance issue.Related issue: #2783.