Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the surface
surface_state_to_conditions
by:surface_state_to_conditions
take the wrapped surface setup, and a localsurface_state
is then made inside.sfc_prognostic_temp
a non-optional argument and removed the splatting (sometimes this is difficult for the compiler to infer).There's several benefits to the first bullet:
surface_state
's can be locally defined, and a full field ofsurface_state
's is not necessary.According to my local tests, this PR allows us to use
always_inline
for this kernel.