New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_diagnostics #2829

Merged

charleskawczynski merged 1 commit into main from ck/refactor_diag_take2

Mar 22, 2024

Member

charleskawczynski commented Mar 22, 2024

This PR refactors get_diagnostics:

remove return statements from map (it's a bit confusing because return doesn't return from the function)
Moves the writers @info statement intoget_diagnostics


          Refactor get_diagnostics

097de50

charleskawczynski added the Refactor label

charleskawczynski enabled auto-merge

March 22, 2024 14:43

Member Author

charleskawczynski commented Mar 22, 2024

This is a baby-step from #2643.

charleskawczynski added this pull request to the merge queue

Merged via the queue into main with commit 3f63038

11 checks passed

charleskawczynski deleted the ck/refactor_diag_take2 branch

March 22, 2024 16:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels