Add function barrier to orchestrate diagnostics #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/diag_func_bar
branch
from
aa689da to
1ce7f1c
Compare
|
It looks like this had a pretty big impact. |
|
Before: 
After: 
(this change is from the first commit) |
charleskawczynski
force-pushed
the
ck/diag_func_bar
branch
from
2daaca9 to
dadaca3
Compare
charleskawczynski
force-pushed
the
ck/diag_func_bar
branch
from
dadaca3 to
25301fc
Compare
|
Indeed, this is much nicer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function barrier to orchestrate diagnostics, in hopes to fix some of the diagnostics allocations (#2831.)
I actually kind of like this better anyway, since it's more clear what variables we're using in closures.