Separate precipitation sources and sinks #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
approved these changes
Mar 28, 2024
src/parameterized_tendencies/microphysics/microphysics_wrappers.jl
Outdated
Show resolved
Hide resolved
trontrytel
commented
Mar 28, 2024
| (; ᶜts) = p.precomputed | ||
| (; ᶜS_ρq_tot) = p.precipitation | ||
| cm_params = CAP.microphysics_params(params) | ||
| thermo_params = CAP.thermodynamics_params(params) | ||
| #TODO missing limiting by q_tot/Δt |
There was a problem hiding this comment.
It seems that I lied and there are some small changes in the mse for the 0-moment scheme. I think they are coming from the fact that now I'm using q_tot_precipitation_sources function which does limit the tendency by q_tot / dt. I think this is better than before, so I'll bump the ref counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
microphysics_warppersfilecompute_precipitation_cachefunction for the 1-moment scheme. Hopefully this is where we will dispatch between w/wo SGS modelq_tot_precipitation_sourcesfor the 0-moment microphysics.This should not introduce any changes in the behavior.