Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use specific humidity as precipitation threshold #2859

Merged
merged 2 commits into from
Apr 1, 2024
Merged

use specific humidity as precipitation threshold #2859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a387ec3
use specific humidity as precipitation threshold
szy21 Mar 31, 2024
9f3be77
bump ref counter
szy21 Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion regression_tests/ref_counter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
157
158

# 158:
# - Switched back the precipitation threshold defintion in the
# 0-moment scheme to specific humidity
# 157:
# - For the grid mean precipitation tendency in the 0-moment scheme:
# - added limiting by q_tot/dt
Expand Down
9 changes: 1 addition & 8 deletions src/parameterized_tendencies/microphysics/microphysics_wrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,7 @@ function q_tot_precipitation_sources(
qₜ::FT,
ts,
) where {FT <: Real}
return -min(
max(qₜ, 0) / dt,
-CM0.remove_precipitation(
cmp,
PP(thp, ts),
TD.q_vap_saturation(thp, ts),
),
)
return -min(max(qₜ, 0) / dt, -CM0.remove_precipitation(cmp, PP(thp, ts)))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trontrytel I think this changes both grid-scale and subgrid-scale?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I bet we could calibrate the parameter value for saturation based to make things stable. But this is easier

end

"""
Expand Down
Loading