Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to turn off tendencies #2864

Merged
merged 1 commit into from
Apr 2, 2024
Merged

add an option to turn off tendencies #2864

merged 1 commit into from
Apr 2, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Apr 1, 2024

Purpose

Adds an option to turn off grid-scale or subgrid-scale tendencies for edmf tests. I didn't add an option to turn off both tendencies as I don't think that's very useful. Also adds a prognostic edmf diffusion only test.

Closes #2863

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 force-pushed the zs/sgs_tendency branch from dcb0d4e to 0ce568c Compare April 1, 2024 18:36
@trontrytel trontrytel self-requested a review April 1, 2024 18:55
@szy21 szy21 force-pushed the zs/sgs_tendency branch 7 times, most recently from 636edbf to e0aee8b Compare April 1, 2024 22:47
@szy21
Copy link
Member Author

szy21 commented Apr 1, 2024

@trontrytel I addressed your comments and gave up on making it work on GPU - would you like to take a look again?

@szy21 szy21 added the API label Apr 1, 2024
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@szy21 szy21 force-pushed the zs/sgs_tendency branch from e0aee8b to 25feb63 Compare April 1, 2024 23:12
@szy21 szy21 added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit abf9d1e Apr 2, 2024
9 of 11 checks passed
@szy21 szy21 deleted the zs/sgs_tendency branch April 2, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prognostic edmf diffusion only aquaplanet simulation
2 participants