update pi groups in entrainment and detrainment #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
commented
Apr 6, 2024
| value = 0 | ||
|
|
||
| [pressure_normalmode_drag_coeff] | ||
| value = 20.0 |
There was a problem hiding this comment.
This value is different from Costa's namelist because of differences in the nonhydrostatic pressure drag (using scale height in climaatmos but updraft top in tc).
trontrytel
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Updates to the new pi groups in entrainment and detrainment closure and adds a bomex case that uses the pi group closure. It doesn't break although the results don't look good. I would like to merge it in first as it would be easier to test it further.
To-do
Content