Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSPKnoth and make it default #3019

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Add SSPKnoth and make it default #3019

merged 5 commits into from
Jun 17, 2024

Conversation

Sbozzolo
Copy link
Member

WIP

@Sbozzolo Sbozzolo force-pushed the gb/rosenbrock branch 4 times, most recently from 4fd237e to f922fbd Compare May 23, 2024 18:39
@Sbozzolo Sbozzolo force-pushed the gb/rosenbrock branch 5 times, most recently from 1dc8103 to 320441c Compare June 6, 2024 17:23
@Sbozzolo Sbozzolo marked this pull request as ready for review June 6, 2024 19:33
@szy21 szy21 mentioned this pull request Jun 16, 2024
Closed
@Sbozzolo Sbozzolo requested a review from szy21 June 17, 2024 17:04
szy21
szy21 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me, thanks!

@Sbozzolo Sbozzolo added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 70dcaae Jun 17, 2024
10 of 11 checks passed
@Sbozzolo Sbozzolo deleted the gb/rosenbrock branch June 17, 2024 18:32
This was referenced Jun 18, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees

@Sbozzolo Sbozzolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sbozzolo @szy21