Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precipitation surface fluxes for 1M microphysics #3084

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

trontrytel
Copy link
Member

@trontrytel trontrytel commented Jun 12, 2024

This PR adds the surface precipitation fluxes for the 1M microphysics scheme. I'm not super sure if this will be correct with topography, but I tried and had support from @dennisYatunin

It also renames the 0M precipitation fluxes from col_integrated_rain (and snow) to surface_rain_flux (and snow). It is a breaking release because of this. I will follow up with a PR to the Coupler.

I added surface precipitation plots whenever I saw surface evaporation plots in the CI.

@trontrytel trontrytel self-assigned this Jun 12, 2024
@trontrytel trontrytel force-pushed the aj/surface_precip_fluxes branch from 25f8b0e to fb17c7a Compare June 13, 2024 21:42
@trontrytel trontrytel marked this pull request as ready for review June 13, 2024 22:16
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I may do the version update in a separate PR, especially that it is a breaking release (and there will probably be a version update tomorrow or Monday). But up to you.

src/diagnostics/core_diagnostics.jl Outdated Show resolved Hide resolved
src/parameterized_tendencies/microphysics/precipitation.jl Outdated Show resolved Hide resolved
@trontrytel
Copy link
Member Author

Thanks! I may do the version update in a separate PR, especially that it is a breaking release (and there will probably be a version update tomorrow or Monday). But up to you.

Sure! Yes, it would be great to do the version update after this is merged in. So that I can also update the Coupler and run the simulations with land there

@trontrytel trontrytel force-pushed the aj/surface_precip_fluxes branch from aaacbf7 to a0e2640 Compare June 14, 2024 22:42
@trontrytel trontrytel force-pushed the aj/surface_precip_fluxes branch from a0e2640 to e1f741d Compare June 14, 2024 23:04
@trontrytel trontrytel added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 3de6d58 Jun 15, 2024
11 checks passed
@trontrytel trontrytel deleted the aj/surface_precip_fluxes branch June 15, 2024 00:28
@szy21
Copy link
Member

szy21 commented Jun 16, 2024

Just a heads up, I noticed that the 1M run in this week's build breaks after ~5 days: https://buildkite.com/clima/climaatmos-gpulongruns/builds/206#01901a45-511a-47d8-a869-666664bc3d9b. It seems we don't have a regression test for microphysics, but this seems to be the only PR that is related. Maybe double check the change in the tendency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants