-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precipitation surface fluxes for 1M microphysics #3084
Conversation
25f8b0e
to
fb17c7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I may do the version update in a separate PR, especially that it is a breaking release (and there will probably be a version update tomorrow or Monday). But up to you.
Sure! Yes, it would be great to do the version update after this is merged in. So that I can also update the Coupler and run the simulations with land there |
aaacbf7
to
a0e2640
Compare
a0e2640
to
e1f741d
Compare
Just a heads up, I noticed that the 1M run in this week's build breaks after ~5 days: https://buildkite.com/clima/climaatmos-gpulongruns/builds/206#01901a45-511a-47d8-a869-666664bc3d9b. It seems we don't have a regression test for microphysics, but this seems to be the only PR that is related. Maybe double check the change in the tendency? |
This PR adds the surface precipitation fluxes for the 1M microphysics scheme. I'm not super sure if this will be correct with topography, but I tried and had support from @dennisYatunin
It also renames the 0M precipitation fluxes from
col_integrated_rain
(and snow) tosurface_rain_flux
(and snow). It is a breaking release because of this. I will follow up with a PR to the Coupler.I added surface precipitation plots whenever I saw surface evaporation plots in the CI.