Parameterize RCEMIPII sst distribution #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmschmitt519
changed the title
szy21
reviewed
Jul 8, 2024
Comment on lines
+51
to
+57
| Base.@kwdef struct SurfaceTemperatureParameters{FT} <: ASTP | ||
| SST_mean::FT | ||
| SST_delta::FT | ||
| SST_wavelength::FT | ||
| SST_wavelength_latitude::FT | ||
| end | ||
|
|
There was a problem hiding this comment.
@nefrathenrici Is it better to group parameters in a struct like this or add them to ClimaAtmosParameters?
There was a problem hiding this comment.
I grouped them like this so they would be broadcasted correctly into surface_state_to_conditions. ClimaAtmosParameters never gets passed into this function, where surface_temperature is called.
cmschmitt519
force-pushed
the
cs/rcemip_config2
branch
from
e8b019a
to
6d711dd
Compare
cmschmitt519
force-pushed
the
cs/rcemip_config2
branch
2 times, most recently
from
990a278
to
1a7e276
Compare
cmschmitt519
force-pushed
the
cs/rcemip_config2
branch
from
1a7e276
to
f651381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add parameters for SST distribution
Modify Earth rotation and ocean albedo for RCEMIP
Keep short run configurations in model configs
To-do
Content