Fix isdac radiation broadcast #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to compute flux before `ᶜdivᵥ` until we resolve: CliMA/ClimaCore.jl#1989
haakon-e
force-pushed
the
he/isdac-fix
branch
from
13550fc
to
2d704df
Compare
akshaysridhar
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Need to compute radiation flux before applying
ᶜdivᵥuntil we resolve this PR: CliMA/ClimaCore.jl#1989.Update config file so simulation runs successfully once #3059 is merged.
Note: can merge this now, since the isdac test case from #3025 is set to soft fail.
Note2: Once #3059 is merged, add
Val{:les_isdac_box},toLESBoxPlots(which is defined there)To-do
Content