Pass subset of ClimaAtmosParameters to detrainment

[charleskawczynski]

This PR passes a subset of ClimaAtmosParameters to detrainment, as we are near hitting the limit of parameter memory space when running on the gpu.

[szy21]

Thanks! We can just replace turbconv_params with tc_params in some of the functions?

[charleskawczynski]

Thanks! We can just replace turbconv_params with tc_params in some of the functions?

I renamed tc_params -> turbconv_params across the board.

[szy21]

Hmm, somehow the reproducibility test failed. I don't think this should change MSE though?

[charleskawczynski]

Hmm, somehow the reproducibility test failed. I don't think this should change MSE though?

Yeah, that's strange. My best guess is that it ran on a different machine? Or there are still issues with the reproducibility test infrastructure that need worked out. I'm working on adding more unit tests now.

[charleskawczynski]

Please let me know if this was sufficient to get your example working (cc @szy21). If not, I can do a followup with updating the actual broadcast expression, which I think could have a bigger impact since the local geometry is passed in.

[szy21]

Please let me know if this was sufficient to get your example working (cc @szy21). If not, I can do a followup with updating the actual broadcast expression, which I think could have a bigger impact since the local geometry is passed in.

Yes, it seems to work, thanks!