Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logging for preset comms device #3459

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: logging for preset comms device #3459

merged 1 commit into from
Nov 27, 2024

Conversation

haakon-e
Copy link
Member

@haakon-e haakon-e commented Nov 26, 2024 •
edited
Loading

Correctly set Logging options if comms_ctx is already supplied to AtmosConfig.

Sbozzolo
Sbozzolo approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haakon-e haakon-e added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 66f99dc Nov 27, 2024
15 of 16 checks passed
@haakon-e haakon-e deleted the he/mpi-setup branch November 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakon-e @Sbozzolo