Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use squeue to find a Slurm job's status #121

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

nefrathenrici
Copy link
Member

Purpose

This PR removes dependency on sacct and slurmdbd, closing #115.

Content

On important consequence: We no longer track job failures for the SlurmBackend. Any job not found in the queue is just marked as completed.


  • I have read and checked the items on the review checklist.

@nefrathenrici nefrathenrici force-pushed the ne/improve_slurm_job_status branch 2 times, most recently from 72b4bd4 to 1736c9f Compare December 13, 2024 23:23
@nefrathenrici nefrathenrici force-pushed the ne/improve_slurm_job_status branch from 1736c9f to 5a6ae95 Compare December 13, 2024 23:44
@nefrathenrici nefrathenrici merged commit 60be971 into main Dec 14, 2024
7 checks passed
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (81dbec4) to head (5a6ae95).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/slurm.jl 0.00% 22 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #121   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        357     370   +13     
=====================================
- Misses       357     370   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant