Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SampleSuccGauss() EKP failure handler, fill crashed sim output with NaNs #37

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

nefrathenrici
Copy link
Member

Since we already use kill-on-invalid-dep for sbatch scripts, this satisfies the minimal error handling requirement.
Closes #22

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e82838) 50.00% compared to head (5f03aef) 49.09%.

Files Patch % Lines
src/atmos_interface.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   50.00%   49.09%   -0.91%     
==========================================
  Files           3        3              
  Lines          54       55       +1     
==========================================
  Hits           27       27              
- Misses         27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nefrathenrici nefrathenrici changed the title Add SampleSuccGauss() EKP failure handler Add SampleSuccGauss() EKP failure handler, fill model output with NaNs Dec 5, 2023
@nefrathenrici nefrathenrici changed the title Add SampleSuccGauss() EKP failure handler, fill model output with NaNs Add SampleSuccGauss() EKP failure handler, fill crashed sim output with NaNs Dec 5, 2023
@nefrathenrici nefrathenrici merged commit e5c1415 into main Dec 5, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper failure handling
1 participant