Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a perfect model example using SurfaceFluxes.jl #52

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add a perfect model example using SurfaceFluxes.jl #52

merged 1 commit into from
Mar 12, 2024

Conversation

LenkaNovak
Copy link
Contributor

@LenkaNovak LenkaNovak commented Feb 22, 2024 •
edited
Loading

closes #53

  • I have read and checked the items on the review checklist.

@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.56%. Comparing base (96b1fb7) to head (67680ba).

Files Patch % Lines
src/model_interface.jl 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   65.00%   69.56%   +4.56%     
==========================================
  Files           4        4              
  Lines          80       69      -11     
==========================================
- Hits           52       48       -4     
+ Misses         28       21       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akshaysridhar akshaysridhar mentioned this pull request Mar 1, 2024
Draft
2 tasks
@LenkaNovak LenkaNovak force-pushed the ln/sf-test branch 6 times, most recently from 2d6d98a to b26ed85 Compare March 9, 2024 03:35
@LenkaNovak LenkaNovak marked this pull request as ready for review March 11, 2024 18:41
nefrathenrici
nefrathenrici reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Lenka! I really like the new interface. I think we need to deal with the different environments a bit better (mainly plots), but that can be done in the future.

experiments/sphere_held_suarez_rhoe_equilmoist/Manifest.toml Outdated Show resolved Hide resolved
plot/Manifest.toml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
src/model_interface.jl Outdated Show resolved Hide resolved
test/Manifest_old.toml Outdated Show resolved Hide resolved
experiments/pipeline.jl Show resolved Hide resolved
experiments/surface_fluxes_perfect_model/observation_map.jl Outdated Show resolved Hide resolved
experiments/surface_fluxes_perfect_model/sf_model.jl Outdated Show resolved Hide resolved
nefrathenrici
nefrathenrici approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! I just had minor comments about the compat

experiments/sphere_held_suarez_rhoe_equilmoist/Project.toml Outdated Show resolved Hide resolved
experiments/surface_fluxes_perfect_model/Project.toml Show resolved Hide resolved
akshaysridhar
akshaysridhar approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@akshaysridhar akshaysridhar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LenkaNovak, I've left brief comments. LGTM otherwise!

@akshaysridhar akshaysridhar added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 12, 2024
@LenkaNovak
SF test
67680ba 
add pipeline to sf

runs sf

runs sf

plots

interface

interface

interface runs

toml vec

test - b_m

more plots

test

test

runs

tune

label fix

sf clean

bash reproduces jl

obs_map -> exp_id

plots

atmos wip

deps

docs and format

tests

tests pass

deps fail

deps fixed

docs

test fix

gitignore

test fix

try

try - inst

try - rm mani

try - insol

try - sync exp project with test

deps - rm atmos test

deps

deps - rm atmos test

clean up

revs

atmos project

rm old Mani

revs2
@LenkaNovak LenkaNovak merged commit caeca40 into main Mar 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nefrathenrici nefrathenrici nefrathenrici approved these changes

@akshaysridhar akshaysridhar akshaysridhar approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a perfect model example using SurfaceFluxes.jl
3 participants
@LenkaNovak @akshaysridhar @nefrathenrici