Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up repo #6

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Set up repo #6

merged 1 commit into from
Aug 14, 2023

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Aug 1, 2023

Closes #5

Content:

Folder structure:

  • plot: scripts for plotting Atmos simulation results. Currently just one contour plot.
  • examples: specific calibration examples (moist rho e held suarez first)
  • src: generalized pipeline, forward ensemble interface, data processing for observation map
  • docs: just a landing page for now
  • test: tests for src

Other repo utilities:

  • .dev: formatter, up deps script
  • .gitignore
  • .github: basic github actions - will add test action once I add tests

Copy link

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the peripherals look great,

Just two questions from me:

  • In the examples/moist_held_suarez there is the yml, but where is the "script" to initiate a run?
  • is plot a separate directory to avoid loading Makie etc into src?

Once these are answered/resolved I'd be happy for merge

@nefrathenrici
Copy link
Member Author

nefrathenrici commented Aug 12, 2023

In the examples/moist_held_suarez there is the yml, but where is the "script" to initiate a run?

I have an initialization script and a single iteration script, but figured it would be better to keep this as a small initial PR and match the plan set out in #4. Clean issue/pr pairs and all that! I'm happy to add it in here if you think it's better.

is plot a separate directory to avoid loading Makie etc into src?

Yep, I think it's cleaner to separate it out.

cc @odunbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up repository structure, github actions, Julia project
2 participants