Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ClimaUtilities.jl CallbackManager module #423

Open
4 of 5 tasks
Tracked by #39
juliasloan25 opened this issue Sep 14, 2023 · 0 comments · May be fixed by #429 or #952
Open
4 of 5 tasks
Tracked by #39

Use ClimaUtilities.jl CallbackManager module #423

juliasloan25 opened this issue Sep 14, 2023 · 0 comments · May be fixed by #429 or #952
Assignees
@juliasloan25
Labels
🍃 leaf Issue coupled to a PR

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Sep 14, 2023 •
edited
Loading

Switch from using ClimaCoupler.jl TimeManager module to using shared ClimaUtilities.jl TimeManager.

See CliMA/ClimaUtilities.jl#9 for detailed interface/functionality changes.

Closed by #952
tracked by CliMA/ClimaUtilities.jl#39

To Do

  • Delete ClimaCoupler.jl TimeManager module
  • Move CoupledSimulation-specific functions (current_date, update_firstdayofmonth!) from src/TimeManager.jl to src/Interfacer.jl
  • Update trigger_callback function calls for new interface
    • src/Diagnostics.jl, experiments/AMIP/modular/coupler_driver.jl
  • Update files using ClimaCoupler.jl TimeManager to load ClimaUtilities.jl module instead
  • rename cs.dates.date -> cs.dates.current_date for clarity
@juliasloan25 juliasloan25 self-assigned this Sep 14, 2023
This was referenced Sep 14, 2023
Closed
Merged
@juliasloan25 juliasloan25 added the 🍃 leaf Issue coupled to a PR label Sep 15, 2023
@juliasloan25 juliasloan25 linked a pull request Sep 18, 2023 that will close this issue
Open
1 task
@LenkaNovak LenkaNovak added this to the O5.1.5 (coupler) ClimaUtilities.jl - shared utility package milestone Feb 21, 2024
@juliasloan25 juliasloan25 mentioned this issue Apr 17, 2024
Open
4 tasks
@juliasloan25 juliasloan25 removed this from the O5.1.5 (coupler) ClimaUtilities.jl - shared utility package milestone Apr 17, 2024
@juliasloan25 juliasloan25 changed the title Use ClimaUtilities.jl TimeManager module Use ClimaUtilities.jl CallbackManager module Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Milestone
No milestone
2 participants
@LenkaNovak @juliasloan25