Add TimeManager module #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2023
Closed
juliasloan25
force-pushed
the
js/timemanager
branch
5 times, most recently
from
6b156ff to
d426f11
Compare
kmdeck
approved these changes
Sep 18, 2023
LenkaNovak
approved these changes
Sep 18, 2023
| # TimeManager | ||
|
|
||
| This module contains functions that handle dates and times | ||
| in simulations. The functions in this module often call |
There was a problem hiding this comment.
"coupled simulations" may be more accurate?
There was a problem hiding this comment.
Some of these functions (e.g. to_datetime) are used in the bucket model in ClimaLSM, which can be run standalone or in a coupled simulation, so I think it makes sense to keep the comment more general
szy21
reviewed
Sep 19, 2023
juliasloan25
force-pushed
the
js/timemanager
branch
2 times, most recently
from
8294a5c to
8574bbb
Compare
juliasloan25
force-pushed
the
js/timemanager
branch
from
8574bbb to
b494073
Compare
|
This branch has been tested within ClimaCoupler and works there, so I'm merging it into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #6
Interface changes from other repos
ClimaCoupler.jl
current_datefunction removed, should be added to ClimaCoupler.jl Utilities moduletrigger_callbackinterface has changed, now increments cutoff date internally (so the result must get saved wherever the function is called from), and takes in callback function to be called if condition is metUse ClimaUtilities.jl CallbackManager module ClimaCoupler.jl#423
ClimaLSM.jl