Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slack uploading process #1074

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Update Slack uploading process #1074

merged 1 commit into from
Nov 11, 2024

Conversation

ph-kev
Copy link
Member

@ph-kev ph-kev commented Nov 8, 2024

closes #1073 - The upload process to Slack fails for the new leaderboard due to different file names. This PR fixes this issue.

@ph-kev ph-kev requested a review from juliasloan25 November 8, 2024 19:50
@juliasloan25
Copy link
Member

Do we need to replace the removed convert commands with commands using updated filenames? If not, why is it okay to remove them altogether?

@ph-kev
Copy link
Member Author

ph-kev commented Nov 11, 2024

Do we need to replace the removed convert commands with commands using updated filenames? If not, why is it okay to remove them altogether?

I believe those commands were used to put all the bias plots for each of the season in one plot. With the updated leaderboard, this is now done in the script to make the leaderboard. Thus, the removed convert commands are not necessary anymore and it is okay to remove them altogether.

The only relevant command is the last one which search for the files with bias_*.png and upload them to Slack which should work because all the new leaderboard files are named "bias_*.png".

@juliasloan25
Copy link
Member

Do we need to replace the removed convert commands with commands using updated filenames? If not, why is it okay to remove them altogether?

I believe those commands were used to put all the bias plots for each of the season in one plot. With the updated leaderboard, this is now done in the script to make the leaderboard. Thus, the removed convert commands are not necessary anymore and it is okay to remove them altogether.

The only relevant command is the last one which search for the files with bias_*.png and upload them to Slack which should work because all the new leaderboard files are named "bias_*.png".

Sounds good, thank you for the explanation!

@ph-kev ph-kev merged commit d7a35a5 into main Nov 11, 2024
11 checks passed
@ph-kev ph-kev deleted the kp/slack-upload branch November 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack upload
2 participants