Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use depression-filled landsea mask #1100

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Use depression-filled landsea mask #1100

merged 2 commits into from
Dec 5, 2024

Conversation

Sbozzolo
Copy link
Member

Switch to using the new land mask computed by filling inland basins instead of looking at elevation on sea level

@Sbozzolo Sbozzolo marked this pull request as ready for review November 27, 2024 23:24
@Sbozzolo Sbozzolo force-pushed the gb/landsea branch 5 times, most recently from e66a607 to 47f7bf8 Compare December 3, 2024 16:27
@Sbozzolo Sbozzolo requested a review from juliasloan25 December 4, 2024 17:49
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The orography dataset is also used by the cloudy slabplanet driver so we need to update that too.

It looks like there are some very minor behavioral changes in the buildkite runs, which is to be expected.

@Sbozzolo Sbozzolo enabled auto-merge December 4, 2024 23:45
@Sbozzolo Sbozzolo changed the title Use lake-filled landsea mask Use depression-filled landsea mask Dec 5, 2024
Switch to using the new land mask computed by filling inland basins
instead of looking at elevation on sea level.

Details of the mask can be found at:
https://github.com/CliMA/ClimaArtifacts/tree/main/landsea_mask
@Sbozzolo Sbozzolo merged commit c56cac5 into main Dec 5, 2024
9 checks passed
@Sbozzolo Sbozzolo deleted the gb/landsea branch December 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants