-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug GPU conservation #614
Conversation
a2a577d
to
f108082
Compare
bcb054c
to
051a84d
Compare
4947bb5
to
aa50f3a
Compare
19e5f07
to
a3cdf37
Compare
75c244f
to
07b5e0c
Compare
714db30
to
4b48092
Compare
CPU (left) vs GPU (right) based on @juliasloan25's investigation: |
Which runs are these plots from? It looks like we have |
4793f89
to
6146f45
Compare
The plots above are was for slabplanet with static albedo. Thanks for setting off the new runs... 🤞 |
Hmm, keeping the rad constant doesn't seem to help. Would it be possible to run for 400s and add more debug plots in the coupling loop (with |
Sure! Do you think 400s will be enough? I could also run for something like 6 hours and plot every hour |
I would try 400s it for now (in case the first time step is overridden by the initial |
ff4e8ee
to
122a128
Compare
06d13aa
to
e3e2088
Compare
a3b8ef5
to
464e73c
Compare
464e73c
to
37ebde4
Compare
I've added tests to compare the states of each component model simulation at the end of the simulation between CPU and GPU. Looking at slabplanet with static albedo run for 400s, we see that the land and ocean states are approximately equal between CPU and GPU, but the land state is not. The max difference in specific atmos variables is shown below. Given that the only state with differences after 400s is the atmosphere, it will be helpful to set up CPU/GPU conservation tests in atmos. slabplanet: albedo from static map (CPU vs GPU) - build
|
@@ -0,0 +1,111 @@ | |||
import DelimitedFiles as DLM | |||
using Statistics | |||
import ClimaCoupler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need this
this has been resolved in #733 |
Purpose
Debug conservation difference between CPU and GPU #607
To-do
Content