-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure component models #647
Conversation
b47c122
to
9c24dcc
Compare
9c24dcc
to
18856c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the rebase removed some of the changes in the previous PR, e.g. Spaces -> ClimaCore.Spaces
, and perhaps some of the imports. It may be good to look over the changes here just to double check. It would be good to check that there are no behavior changes both for slabplanet and AMIP before merging. Otherwise LGTM, thank you for doing this! Approving, but I'm happy to take a look again if needed.
|
||
Extension of Interfacer.get_field to get the net TOA radiation, which is a sum of the | ||
upward and downward longwave and shortwave radiation. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed recently that sometimes the docstrings of extensions can sometimes cause the extensions to be ignored. It doesn't seem to be problematic here, but we should probably decide on a convention (Clima wide) as to how to deal with this. (not as part of this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point!
0a83515
to
0320449
Compare
0320449
to
1e66ec0
Compare
Purpose
separate required vs model-specific (internal) functions and objects in component model files
follows off of #644
Content
<model>.jl
get_field
andupdate_field!
methods for easier comparison/readability