Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coupler driver docs #668

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update coupler driver docs #668

merged 1 commit into from
Mar 6, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Mar 5, 2024 •
edited
Loading

Closes #651

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak marked this pull request as ready for review March 5, 2024 15:32
@LenkaNovak LenkaNovak requested a review from juliasloan25 March 5, 2024 15:34
juliasloan25
juliasloan25 reviewed Mar 5, 2024
View reviewed changes
experiments/AMIP/coupler_driver.jl Outdated Show resolved Hide resolved
experiments/AMIP/coupler_driver.jl Outdated Show resolved Hide resolved
experiments/AMIP/coupler_driver.jl Show resolved Hide resolved
experiments/AMIP/coupler_driver.jl Outdated
new_p = get_new_cache(atmos_sim, cs.fields)
CA.SurfaceConditions.update_surface_conditions!(atmos_sim.integrator.u, new_p, atmos_sim.integrator.t) # sets T_sfc (but SF calculation not necessary - CA)
CA.SurfaceConditions.update_surface_conditions!(atmos_sim.integrator.u, new_p, atmos_sim.integrator.t) ## sets T_sfc (but SF calculation not necessary - CA)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the comment mean - "SF calculation not necessary" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment that the CA interface requires an SF calculation to update its surface conditions, but this should not be necessary. In other words, the setting of surface conditions should be split from calculating fluxes in in CA. I clarified the comment.

src/FieldExchanger.jl Show resolved Hide resolved
@LenkaNovak LenkaNovak force-pushed the ln/driver-update branch 3 times, most recently from 782223b to 75fe488 Compare March 6, 2024 15:14
juliasloan25
juliasloan25 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you Lenka :)

@LenkaNovak
add docs
086d1e6 
rev

rebase fixes

format
@LenkaNovak LenkaNovak merged commit 363305e into main Mar 6, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up tutorial/driver
2 participants
@LenkaNovak @juliasloan25