Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing docstrings #686

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add missing docstrings #686

merged 1 commit into from
Mar 12, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Mar 11, 2024 •
edited
Loading

closes #676

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak requested a review from juliasloan25 March 11, 2024 19:26
@LenkaNovak LenkaNovak marked this pull request as ready for review March 11, 2024 20:48
juliasloan25
juliasloan25 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you Lenka!

src/Diagnostics.jl Outdated Show resolved Hide resolved
src/Diagnostics.jl Outdated Show resolved Hide resolved
docs/src/conservation.md Outdated Show resolved Hide resolved
@LenkaNovak LenkaNovak force-pushed the ln/missing-docstrings branch from 6811cbb to 37c2f4f Compare March 12, 2024 18:22
@LenkaNovak LenkaNovak merged commit 4b1fcec into main Mar 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing docstrings
2 participants
@LenkaNovak @juliasloan25