Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps #694

Merged
merged 2 commits into from
Mar 14, 2024
Merged

update deps #694

merged 2 commits into from
Mar 14, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Mar 14, 2024 •
edited
Loading

Purpose

update to latest dependencies
closes #690

Content

  • CLIMAParameters -> ClimaParams: This PR touches a lot of files because of the renaming of ClimaParams
  • ClimaLand v0.11: Albedo struct types were renamed, and BucketModelParameters constructor changed following ClimaLand's switch to using ClimaParams. Note that for some parameters we aren't using the defaults (but probably could)
  • ClimaCore v0.13: Removed a few deprecated functions, which were only being used in seabreeze

@juliasloan25 juliasloan25 requested a review from LenkaNovak March 14, 2024 19:10
LenkaNovak
LenkaNovak approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the static albedo map corrupted for that one run on Buildkite? Maybe it'll work if you trigger a new build?

@juliasloan25
Copy link
Member Author

LGTM. Is the static albedo map corrupted for that one run on Buildkite? Maybe it'll work if you trigger a new build?

Yes! The agent was lost while the file was being accessed, so it got corrupted. I'm clearing the depot, and then it should work when I re-build

@juliasloan25 juliasloan25 enabled auto-merge March 14, 2024 22:12
@juliasloan25 juliasloan25 merged commit 4b69bda into main Mar 14, 2024
7 checks passed
This was referenced Mar 14, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update to Land v0.11, Atmos v0.22
2 participants
@juliasloan25 @LenkaNovak