Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seasonal cycle to leaderboard #695

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add seasonal cycle to leaderboard #695

merged 2 commits into from
Apr 3, 2024

Conversation

Sbozzolo
Copy link
Member

This PR adds new bias plots for seasonally averaged variables (4 new figures are produced).

Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Sbozzolo . I'm not sure why the import of ClimaCorePlots is suddenly being problematic. Does it run for you locally?

@Sbozzolo
Copy link
Member Author

Looks great, thanks @Sbozzolo . I'm not sure why the import of ClimaCorePlots is suddenly being problematic. Does it run for you locally?

Yeah, I don't know what's the issue here

@Sbozzolo Sbozzolo marked this pull request as ready for review March 29, 2024 17:54
@Sbozzolo Sbozzolo requested a review from LenkaNovak March 29, 2024 17:55
Sbozzolo and others added 2 commits April 3, 2024 07:51
Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Sbozzolo, thank you! Plots as expected. Looking forward to running this in the longruns.

@Sbozzolo Sbozzolo enabled auto-merge April 3, 2024 14:59
end
plot_biases(cs.dates.date, "total")

MAM, JJA, SON, DJF = Leaderboard.split_by_season(cs.dates.date)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, when we do apply this for longer runs, I presume we'll need to pass in the dates that are consistent with the atmos output here? It may be worth opening an issue for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't need to do that. The code already finds the closest date available.

@Sbozzolo Sbozzolo merged commit 90bb1b0 into main Apr 3, 2024
7 checks passed
@LenkaNovak LenkaNovak mentioned this pull request Apr 9, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants