-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seasonal cycle to leaderboard #695
Conversation
1b64967
to
747dc6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @Sbozzolo . I'm not sure why the import of ClimaCorePlots is suddenly being problematic. Does it run for you locally?
Yeah, I don't know what's the issue here |
57b520d
to
eb8d04b
Compare
Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Sbozzolo, thank you! Plots as expected. Looking forward to running this in the longruns.
end | ||
plot_biases(cs.dates.date, "total") | ||
|
||
MAM, JJA, SON, DJF = Leaderboard.split_by_season(cs.dates.date) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, when we do apply this for longer runs, I presume we'll need to pass in the dates that are consistent with the atmos output here? It may be worth opening an issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't need to do that. The code already finds the closest date available.
This PR adds new bias plots for seasonally averaged variables (4 new figures are produced).