remove closures in driver #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/driver-closures
branch
from
ba5a2dc to
fdc2828
Compare
LenkaNovak
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Thanks for doing this, @juliasloan25. So far, only a couple of minor comments and happy to approve once CI passes.
juliasloan25
force-pushed
the
js/driver-closures
branch
from
fdc2828 to
346ce08
Compare
juliasloan25
force-pushed
the
js/driver-closures
branch
from
346ce08 to
4659852
Compare
charleskawczynski
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove closures over global variables in
coupler_driver.jlto improve performance.This includes changes for: