Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hooks to overwrite atmos albedo #702

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add hooks to overwrite atmos albedo #702

merged 1 commit into from
Mar 20, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Mar 18, 2024 •
edited
Loading

Closes #653

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak mentioned this pull request Mar 18, 2024
Closed
1 task
@LenkaNovak LenkaNovak force-pushed the ln/override-atmos-albedo2 branch 4 times, most recently from 3b115e5 to 65409b0 Compare March 19, 2024 18:47
@LenkaNovak LenkaNovak marked this pull request as ready for review March 19, 2024 20:03
@LenkaNovak LenkaNovak requested a review from szy21 March 19, 2024 20:03
szy21
szy21 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have a few minor questions

experiments/AMIP/Manifest.toml Outdated Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos.jl Show resolved Hide resolved
test/field_exchanger_tests.jl Show resolved Hide resolved
@LenkaNovak LenkaNovak force-pushed the ln/override-atmos-albedo2 branch from 65409b0 to d34a55a Compare March 20, 2024 16:30
@LenkaNovak
hooks
7bd0b96 
runs

clean + format

up mani

albedo checked

clean docs

test fix

fix test Project

revs + codecov

doc clean
@LenkaNovak LenkaNovak force-pushed the ln/override-atmos-albedo2 branch from d34a55a to 7bd0b96 Compare March 20, 2024 16:38
@LenkaNovak LenkaNovak enabled auto-merge March 20, 2024 17:04
@LenkaNovak LenkaNovak merged commit 293635d into main Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overwrite atmos albedo
2 participants
@LenkaNovak @szy21