Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ci plots #716

Merged
merged 1 commit into from
Apr 11, 2024
Merged

adding ci plots #716

merged 1 commit into from
Apr 11, 2024

Conversation

ncapak
Copy link
Collaborator

@ncapak ncapak commented Mar 28, 2024

Purpose

Add diagnostics and CI plots to package so that we can take advantage of ClimaAtmos diagnostics directly

closes #654

Content

Added ci_plots pipeline to coupler_driver, the source was ClimaAtmos
  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak force-pushed the nc/ci_plots branch 2 times, most recently from 994e12d to 12b9eff Compare April 9, 2024 00:20
@LenkaNovak LenkaNovak marked this pull request as ready for review April 9, 2024 00:21
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ncapak! I've added a couple of comments and refined the location of the output. I've also asked @juliasloan25 to take a look for a more impartial review. After that, I'm happy to merge this, and we can apply this more broadly in follow-up PRs. Thanks for your contribution! 🎉

@LenkaNovak LenkaNovak force-pushed the nc/ci_plots branch 2 times, most recently from db54765 to 5adc0d3 Compare April 9, 2024 16:02
@LenkaNovak LenkaNovak force-pushed the nc/ci_plots branch 2 times, most recently from c28017e to 168b2ff Compare April 9, 2024 17:58
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Neeku, thank you! I left some comments - feel free to reach out if anything doesn't make sense or you want to discuss more :)

experiments/AMIP/user_io/ci_plots.jl Show resolved Hide resolved
experiments/AMIP/user_io/ci_plots.jl Outdated Show resolved Hide resolved
experiments/AMIP/coupler_driver.jl Outdated Show resolved Hide resolved
experiments/AMIP/user_io/ci_plots.jl Show resolved Hide resolved
experiments/AMIP/user_io/ci_plots.jl Outdated Show resolved Hide resolved
experiments/AMIP/user_io/ci_plots.jl Outdated Show resolved Hide resolved
experiments/AMIP/user_io/ci_plots.jl Outdated Show resolved Hide resolved
experiments/AMIP/user_io/ci_plots.jl Outdated Show resolved Hide resolved
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@LenkaNovak LenkaNovak force-pushed the nc/ci_plots branch 2 times, most recently from 0bf6fa1 to f8d6544 Compare April 10, 2024 19:18
mv to user_io and add paths

format

format

format

format

up mani

fix rebase

averages for diagnostics

path fix

revs

ci plots for non-perf jobs only

ci plots as arg
@LenkaNovak LenkaNovak merged commit 8a70236 into main Apr 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate ClimaAtmos.Diagnostics plots into our CI
4 participants