Use output dates from atmos.integrator #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenkaNovak
approved these changes
Apr 8, 2024
| @@ -858,20 +858,22 @@ if ClimaComms.iamroot(comms_ctx) | |||
| # Compare against observations | |||
| if t_end > 84600 | |||
| @info "Error against observations" | |||
| output_dates = cs.dates.date0[] .+ Second.(atmos_sim.integrator.sol.t) | |||
There was a problem hiding this comment.
It would be good to add a comment that dt_save_to_sol needs to be consistent with the required averaging. For most of our runs dt_save_to_sol is 10days but the seasonal average using this method would require 1days (for daily averaged data).
|
Confirmed that MAM and DJF differ. 👍 |
9 tasks
|
@Sbozzolo can this be merged? |
|
Was cherry picked in 79594b1 |
auto-merge was automatically disabled
April 19, 2024 00:58
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the leaderboard uses the output dates from atmos.