WIP

src/diagnostics/define_diagnostics.jl

@@ -203,7 +203,7 @@ function define_diagnostics!(land_model)
         short_name = "ra",
         long_name = "Autotrophic Respiration",
         standard_name = "autotrophic_respiration",
-        units = "mol CO2 m^-2 s^-1", # note throughout: make sure what we express as kg or mol, CO2 or C
+        units = "kg C m^-2 s^-1", 
         comments = "The canopy autotrophic respiration, the sum of leaves, stems and roots respiration.",
         compute! = (out, Y, p, t) ->
             compute_autotrophic_respiration!(out, Y, p, t, land_model),
@@ -215,7 +215,7 @@ function define_diagnostics!(land_model)
         short_name = "gs",
         long_name = "Stomatal Conductance",
         standard_name = "stomatal_conductance",
-        units = "m s^-1",
+        units = "mol H2O m^-2 s^-1",
         comments = "The conductance of leaves. This depends on stomatal opening. It varies with factors such as soil moisture or atmospheric water demand.",
         compute! = (out, Y, p, t) ->
             compute_stomatal_conductance!(out, Y, p, t, land_model),
@@ -227,7 +227,7 @@ function define_diagnostics!(land_model)
         long_name = "Canopy Transpiration",
         standard_name = "canopy_transpiration",
         units = "m s^-1",
-        comments = "The water evaporated from the canopy due to leaf transpiration.",
+        comments = "The water evaporated from the canopy due to leaf transpiration (flux of water volume, m^3 of water per m^2 of ground).",
         compute! = (out, Y, p, t) ->
             compute_canopy_transpiration!(out, Y, p, t, land_model),
     )
@@ -238,8 +238,8 @@ function define_diagnostics!(land_model)
         short_name = "crae",
         long_name = "Canopy Aerodynamic Resistance",
         standard_name = "canopy_aerodynamic_resistance",
-        units = "s m^-1", # ??? not sure
-        comments = "The canopy aerodynamic resistance. Aerodynamic resistance (r_a) is a measure of how much the air near the Earth's surface resists the movement of water vapor and heat from the surface into the air.", #?? of steam, leaves, roots?
+        units = "s m^-1", 
+        comments = "The canopy aerodynamic resistance. Aerodynamic resistance (r_a) is a measure of how much the air near the Earth's surface resists the movement of water vapor and heat from the surface into the air.", 
         compute! = (out, Y, p, t) ->
             compute_canopy_aerodynamic_resistance!(out, Y, p, t, land_model),
     )
@@ -272,7 +272,7 @@ function define_diagnostics!(land_model)
         short_name = "cwp",
         long_name = "Canopy Water Potential",
         standard_name = "canopy_water_potential",
-        units = "Pa",
+        units = "m",
         comments = "The water potential of the canopy.",
         compute! = (out, Y, p, t) ->
             compute_canopy_water_potential!(out, Y, p, t, land_model),
@@ -283,8 +283,8 @@ function define_diagnostics!(land_model)
         short_name = "fa",
         long_name = "Cross Section",
         standard_name = "cross_section",
-        units = "m^2 m^-2",
-        comments = "The area of stem relative to ground area.", #??
+        units = "m s^-1",
+        comments = "Flux of water volume per m^2 of plant per second, multiplied by the area index (plant area/ground area).", 
         compute! = (out, Y, p, t) ->
             compute_cross_section!(out, Y, p, t, land_model),
     )
@@ -294,8 +294,8 @@ function define_diagnostics!(land_model)
         short_name = "far",
         long_name = "Root Cross Section",
         standard_name = "Cross Section",
-        units = "m^2 m^-2",
-        comments = "The area of roots relative to ground area.", #??
+        units = "m s^-1",
+        comments = "Flux of water volume per m^2 of root per second, multiplied by the area index (root area/ground area).", 
         compute! = (out, Y, p, t) ->
             compute_cross_section_roots!(out, Y, p, t, land_model),
     )
@@ -394,7 +394,7 @@ function define_diagnostics!(land_model)
         short_name = "nir",
         long_name = "Near Infrared Radiation",
         standard_name = "near_infrared_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of near infrared radiation reaching the canopy.",
         compute! = (out, Y, p, t) ->
             compute_near_infrared_radiation!(out, Y, p, t, land_model),
@@ -405,7 +405,7 @@ function define_diagnostics!(land_model)
         short_name = "anir",
         long_name = "Absorbed Near Infrared Radiation",
         standard_name = "absorbed_near_infrared_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of near infrared radiation absorbed by the canopy.",
         compute! = (out, Y, p, t) ->
             compute_near_infrared_radiation_absorbed!(out, Y, p, t, land_model),
@@ -416,7 +416,7 @@ function define_diagnostics!(land_model)
         short_name = "rnir",
         long_name = "Reflected Near Infrared Radiation",
         standard_name = "reflected_near_infrared_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of near infrared radiation reflected by the canopy.",
         compute! = (out, Y, p, t) ->
             compute_near_infrared_radiation_reflected!(
@@ -433,7 +433,7 @@ function define_diagnostics!(land_model)
         short_name = "tnir",
         long_name = "Transmitted Near Infrared Radiation",
         standard_name = "transmitted_near_infrared_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of near infrared radiation transmitted by the canopy.",
         compute! = (out, Y, p, t) ->
             compute_near_infrared_radiation_transmitted!(
@@ -450,7 +450,7 @@ function define_diagnostics!(land_model)
         short_name = "par",
         long_name = "Photosynthetically Active Radiation",
         standard_name = "photosynthetically_active_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The subset of total radiation that activates photosynthesis reaching the canopy.",
         compute! = (out, Y, p, t) ->
             compute_photosynthetically_active_radiation!(
@@ -467,7 +467,7 @@ function define_diagnostics!(land_model)
         short_name = "apar",
         long_name = "Absorbed Photosynthetically Active Radiation",
         standard_name = "absorbed_photosynthetically_active_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of photosynthetically active radiation absorbed by the leaf. The rest if reflected or transmitted.",
         compute! = (out, Y, p, t) ->
             compute_photosynthetically_active_radiation_absorbed!(
@@ -484,7 +484,7 @@ function define_diagnostics!(land_model)
         short_name = "rpar",
         long_name = "Reflected Photosynthetically Active Radiation",
         standard_name = "reflected_photosynthetically_active_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of photosynthetically active radiation reflected by leaves.",
         compute! = (out, Y, p, t) ->
             compute_photosynthetically_active_radiation_reflected!(
@@ -501,7 +501,7 @@ function define_diagnostics!(land_model)
         short_name = "tpar",
         long_name = "Transmitted Photosynthetically Active Radiation",
         standard_name = "transmitted_photosynthetically_active_radiation",
-        units = "W m^-2",
+        units = "mol photons m^-2 s^-1",
         comments = "The amount of photosynthetically active radiation transmitted by leaves.",
         compute! = (out, Y, p, t) ->
             compute_photosynthetically_active_radiation_transmitted!(
@@ -563,8 +563,8 @@ function define_diagnostics!(land_model)
         short_name = "rain",
         long_name = "Rainfall",
         standard_name = "rainfall",
-        units = "m s^-1", # do we express rainfall as a flux? Check then delete this comment
-        comments = "Precipitation of liquid water.",
+        units = "m s^-1", 
+        comments = "Precipitation of liquid water volume (m^3 of water per m^2 of ground per second).",
         compute! = (out, Y, p, t) ->
             compute_rainfall!(out, Y, p, t, land_model),
     )
@@ -597,7 +597,7 @@ function define_diagnostics!(land_model)
         long_name = "Snowfall",
         standard_name = "snowfall",
         units = "m s^-1",
-        comments = "The precipitation of snow (m s^-1).",
+        comments = "The precipitation of snow in liquid water volume (m^3 of water per m^2 of ground per second).",
         compute! = (out, Y, p, t) ->
             compute_snowfall!(out, Y, p, t, land_model),
     )
@@ -642,7 +642,7 @@ function define_diagnostics!(land_model)
         long_name = "Infiltration",
         standard_name = "infiltration",
         units = "m s^-1",
-        comments = "The flux of liquid water into the soil.",
+        comments = "The flux of liquid water volume into the soil (m^3 of water per m^2 of ground per second).",
         compute! = (out, Y, p, t) ->
             compute_infiltration!(out, Y, p, t, land_model),
     )