-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dss in ClimaODEfunction; update docs #321
Conversation
Update richards_equation.jl remove spurious comma
@kmdeck I think we can merge this (or something like it) now. I forget what state this is in and why we didn't merge it... Does it just need a review? |
I will rebase & revisit! I forget too. |
@kmdeck maybe we can close this now? |
Yes, I think we can! closing since we have currently removed dss! from our simulations (partially, the infrastructure is still there). If we do bring it back, and even if not, I think it would be nice to have a helper function to create the ClimaODEFunction. but we can start that fresh. this PR is very stale. |
Purpose
Closes #293.
Hides some internals from users with respect to setting up the ClimaODEFunction:
-Employs dss! in all tutorials and experiments. internally, whether or not dss! does anything depends on the domain of the model/whether spectral elements are used.
-creates the function get_ClimaODEFunction(model, Y) which creates the clima ode function suitable for the model (implicit/explicit tendencies, jacobian, dss)
To-do
get_ClimaODEFunction(model, Y)
(or do we need to? does it matter if the jacobian is nothing, the update_jacobian function does nothing?)This arises because we have:
AbstractLandModel <: AbstractModel
AbstractImExModel <: AbstractModel
AbstractExpModel <: AbstractModel
currently in this PR, we only have the single method for AbstractModel for all jacobian functions, and for the get_ClimaODEFunction.
Make clear in tutorials when to use explicit steppers vs imex timesteppers. Right now this has to be inferred from the type of the model or type of the component models of a land model.
Content
Creates
get_ClimaODEFunction
, which required a functionmake_jacobian
, and uses this is all tutorials/experimentsReview checklist
I have:
In the Content, I have included