Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI at every PR #374

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Run CI at every PR #374

merged 1 commit into from
Nov 6, 2023

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Nov 6, 2023

Bors is gone.

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 6, 2023

@kmdeck, when this has merged, can you try merging a new PR that removes bors.toml to check that everything works as you would expect?

To merge, you can just click the "Enable auto-merge" button on your PR.

@Sbozzolo Sbozzolo enabled auto-merge November 6, 2023 22:15
@juliasloan25
Copy link
Member

Just to make sure I understand - this change will run the whole CI pipeline on each commit pushed to Github, right? So in terms of changes to workflow, we'll now need to do the following:

  • rebase on main when a PR is ready
  • enable auto-merge when we want to merge a rebased PR (instead of bors r+ as before)

We should also continue using [skip ci] frequently to avoid running all these checks unnecessarily (though this isn't new)

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 6, 2023

Just to make sure I understand - this change will run the whole CI pipeline on each commit pushed to Github, right? So in terms of changes to workflow, we'll now need to do the following:

  • rebase on main when a PR is ready
  • enable auto-merge when we want to merge a rebased PR (instead of bors r+ as before)

We should also continue using [skip ci] frequently to avoid running all these checks unnecessarily (though this isn't new)

Yes, correct. We can enable more granularity if needed. For example, we can exclude draft PRs from buildkite.

@juliasloan25
Copy link
Member

Great, thank you for updating this!

@kmdeck kmdeck self-requested a review November 6, 2023 23:07
@kmdeck
Copy link
Member

kmdeck commented Nov 6, 2023

@juliasloan25 @Sbozzolo I updated the permission to require a review before merging, and then approved this. (this was previously a req, Im not sure why it was not enforced here)

Julia, maybe we can talk more about how to skip CI in certain cases.

Gabriele, will try removing bors.toml before the end of the day

@Sbozzolo Sbozzolo merged commit 8669df0 into main Nov 6, 2023
5 checks passed
This was referenced Nov 6, 2023
@kmdeck kmdeck deleted the gb/update_ci branch November 7, 2023 01:11
mitraA90 pushed a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants