Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EnergyHydrologyParameters #505

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Refactor EnergyHydrologyParameters #505

merged 1 commit into from
Mar 6, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Feb 21, 2024

Same as #481 and #480, adds two new constructors for EnergyHydrologyParameters that use ClimaParams. One takes an FT, one takes a toml.
I also updated the experiment Manifest, for some reason Insolation was not updated.

  EnergyHydrologyParameters(
        ::Type{FT};
        ν,
        ν_ss_om,
        ν_ss_quartz,
        ν_ss_gravel,
        hydrology_cm,
        K_sat,
        S_s,
        θ_r,
        kwargs...,
)

    EnergyHydrologyParameters(
        toml_dict;
        ν,
        ν_ss_om,
        ν_ss_quartz,
        ν_ss_gravel,
        hydrology_cm,
        K_sat,
        S_s,
        θ_r,
        kwargs...,
)

@nefrathenrici nefrathenrici force-pushed the ne/eh_params branch 3 times, most recently from 3164617 to ddfc141 Compare March 1, 2024 18:19
@nefrathenrici nefrathenrici marked this pull request as ready for review March 1, 2024 18:20
@nefrathenrici nefrathenrici force-pushed the ne/eh_params branch 2 times, most recently from 5d9d8e7 to 30f85be Compare March 4, 2024 17:36
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments but I also think it's good to merge as-is

@nefrathenrici nefrathenrici merged commit 7a7d7a5 into main Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants