fix CPU global bucket state #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/cpu-gpu-bug
branch
5 times, most recently
from
cd58afe to
92f9372
Compare
juliasloan25
changed the title
juliasloan25
force-pushed
the
js/cpu-gpu-bug
branch
3 times, most recently
from
22646f9 to
792c95d
Compare
Sbozzolo
force-pushed
the
js/cpu-gpu-bug
branch
4 times, most recently
from
25cd863 to
9bdc567
Compare
Otherwise it crashes for OOM
juliasloan25
commented
Mar 12, 2024
Sbozzolo
reviewed
Mar 12, 2024
Sbozzolo
force-pushed
the
js/cpu-gpu-bug
branch
from
1a836fb to
34362c8
Compare
Sbozzolo
reviewed
Mar 12, 2024
juliasloan25
commented
Mar 12, 2024
Sbozzolo
force-pushed
the
js/cpu-gpu-bug
branch
from
34362c8 to
c5085e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
After #536, we begin to see that output for the global bucket on CPU is incorrect (e.g. build here). This wasn't caught before because in our comparison of cpu/gpu means, we weren't taking the absolute value.
To-do
Array(...)so that memory is allocated for it. A fix for this will be included in ClimaCore v0.13.2 (see ClimaCore PR)