Use ClimaUtilities FileReading/Inputs/Regridding #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/regriddeer_in_climautilities
branch
5 times, most recently
from
5115937 to
c2f4aef
Compare
Sbozzolo
force-pushed
the
gb/regriddeer_in_climautilities
branch
from
c2f4aef to
41fc97d
Compare
kmdeck
reviewed
Mar 28, 2024
Sbozzolo
force-pushed
the
gb/regriddeer_in_climautilities
branch
2 times, most recently
from
cfbb297 to
25e9601
Compare
kmdeck
reviewed
Mar 28, 2024
src/standalone/Bucket/Bucket.jl
Outdated
| @@ -3,6 +3,13 @@ using DocStringExtensions | |||
| using Thermodynamics | |||
| using Dates | |||
| using NCDatasets | |||
| import ClimaUtilities.TimeVaryingInputs | |||
| import ClimaUtilities.DataHandling | |||
| import ClimaUtilities.SpaceVaryingInputs | |||
There was a problem hiding this comment.
do we need both import statements?
import ClimaUtilities.SpaceVaryingInputs
import ClimaUtilities.SpaceVaryingInputs: SpaceVaryingInput
and similar for TVI?
There was a problem hiding this comment.
We don't need the first line for SpaceVaryingInputs, but we need it for TimeVaryingInputs. I want to leave TimeVaryingInput.evaluate! so that it is clear where evaluate! comes from.
kmdeck
approved these changes
Mar 28, 2024
Sbozzolo
force-pushed
the
gb/regriddeer_in_climautilities
branch
from
25e9601 to
2d2ed0f
Compare
4 tasks
juliasloan25
changed the title
juliasloan25
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CliMA/ClimaUtilities.jl#19, I extracted #465 as well as other components and put them into a separate package. This PR uses that package for Space and Time Varying Inputs.
This PR supersedes #465.
Closes #392.