Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ArtifactWrappers from docs, test, standalone bucket #640

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jun 4, 2024

Purpose

Removes artifact wrappers dependence from our docs, test, and src except src/Artifacts.jl

To-do

Future PR (ClimaArtifacts) - add these files to ClimaArtifacts
Future PR (ClimaLand) - update the functions in src/Artifacts.jl
Review

Content

adds a few new files to srcs/Artifacts.jl
removes AW from docs, src/standalone/Bucket
In test/ we had "era5_t2m_sp_u10n_static_dataset_path" and "era5_t2m_sp_u10n_dataset_path" artifacts, but these were not being used anywhere, so I removed them. @juliasloan25 can confirm

Review checklist

I have:

In the Content, I have included

  • relevant unit tests, and integration tests,
  • appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck self-assigned this Jun 4, 2024
@kmdeck kmdeck changed the title remove ArtifactWrappers from docs remove ArtifactWrappers from docs, test, src Jun 4, 2024
@kmdeck kmdeck changed the title remove ArtifactWrappers from docs, test, src remove ArtifactWrappers from docs, test, standalone bucket Jun 4, 2024
@kmdeck kmdeck marked this pull request as ready for review June 4, 2024 19:54
@kmdeck kmdeck requested review from juliasloan25 and Sbozzolo June 4, 2024 19:54
src/Artifacts.jl Outdated Show resolved Hide resolved
@Sbozzolo Sbozzolo self-requested a review June 4, 2024 21:00
@juliasloan25
Copy link
Member

Agreed that "era5_t2m_sp_u10n_static_dataset_path" and "era5_t2m_sp_u10n_dataset_path" weren't being used! Thank you Kat :)

@juliasloan25
Copy link
Member

Is it correct that this is a step towards #580, but doesn't close it because ArtifactWrappers is still being used in src/Artifacts.jl?

@Sbozzolo
Copy link
Member

Sbozzolo commented Jun 4, 2024

Is it correct that this is a step towards #580, but doesn't close it because ArtifactWrappers is still being used in src/Artifacts.jl?

Yes, correct. Now ArtifactsWrapper is more contained

@kmdeck kmdeck enabled auto-merge June 5, 2024 20:58
@kmdeck kmdeck merged commit aeaced7 into main Jun 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants