Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preallocate bucket auxs #643

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Preallocate bucket auxs #643

merged 2 commits into from
Jun 12, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Jun 6, 2024

This PR preallocates some of the Fields that are created when computing the bucket tendency.

New time: 3.6s

https://buildkite.com/clima/climaland-benchmark/builds/355#018fef98-5edd-4f39-9cbd-a11a529eba6f

@Sbozzolo Sbozzolo added the Run benchmarks Add this label to run benchmarks on clima label Jun 6, 2024
@Sbozzolo Sbozzolo force-pushed the gb/preallocate_bucket branch from 193fabe to cca1d39 Compare June 6, 2024 21:01
@Sbozzolo Sbozzolo requested a review from kmdeck June 6, 2024 21:14
@Sbozzolo Sbozzolo force-pushed the gb/preallocate_bucket branch from cca1d39 to 1acf6c0 Compare June 6, 2024 21:14
@Sbozzolo Sbozzolo marked this pull request as ready for review June 6, 2024 21:14
@Sbozzolo Sbozzolo force-pushed the gb/preallocate_bucket branch 2 times, most recently from f0acb88 to a776475 Compare June 12, 2024 16:02
Copy link
Member

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine! I am just wondering if any unit tests need to change to reflect these additions. How are we determining that the behavior doesnt change with this PR?

One other comment is that I think at this point we dont need to improve the bucket performance on its own, but should make changes that improve the performance of all models (e.g. allocations in turbulent_fluxes, net_radiation, etc)

@Sbozzolo Sbozzolo force-pushed the gb/preallocate_bucket branch from a776475 to 748634b Compare June 12, 2024 21:31
@Sbozzolo Sbozzolo force-pushed the gb/preallocate_bucket branch from 748634b to cdcfa5f Compare June 12, 2024 21:32
@Sbozzolo
Copy link
Member Author

I think this looks fine! I am just wondering if any unit tests need to change to reflect these additions. How are we determining that the behavior doesnt change with this PR?

This is a good question. The PR only moves code around, so it things were previously properly tested, they will stay properly tested. I added unit tests to check that things should be consistent.

One other comment is that I think at this point we dont need to improve the bucket performance on its own, but should make changes that improve the performance of all models (e.g. allocations in turbulent_fluxes, net_radiation, etc)

I agree!

@Sbozzolo Sbozzolo merged commit 20230d9 into main Jun 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run benchmarks Add this label to run benchmarks on clima
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants