-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag v0.12.4 #668
tag v0.12.4 #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm just surprised by the new packages in the manifests
@@ -1823,6 +1946,38 @@ version = "3.7.2+0" | |||
uuid = "ca575930-c2e3-43a9-ace4-1e988b2c1908" | |||
version = "1.2.0" | |||
|
|||
[[deps.NonlinearSolve]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that so many new deps are added from just updating the versions. Do you know which package is bringing these in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No... I was surprised too...
No deps change in Project.toml.
Is it possible that there are change in the Manifests due to what I did on other branches? (even if I updated them from this new branch).
Does it change for you if you update locally? Maybe we shouldn't merge yet. This is weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sbozzolo I have ClimaDiagnostics in the Diagnostic branch. Could that explain this?
(But I thought the Manifest would refresh as I checked out from main, just up ClimaLand from 0.12.3 to 0.12.4 and up the Manifest in docs and .buildkite)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be mostly from ( ? )
[[deps.DiffEqCallbacks]]
deps = ["DataStructures", "DiffEqBase", "ForwardDiff", "Functors", "LinearAlgebra", "Markdown", "NLsolve", "Parameters", "RecipesBase", "RecursiveArrayTools", "SciMLBase", "StaticArraysCore"]
git-tree-sha1 = "ee954c8b9d348b7a8a6aec5f28288bf5adecd4ee"
deps = ["DataStructures", "DiffEqBase", "ForwardDiff", "Functors", "LinearAlgebra", "Markdown", "NonlinearSolve", "Parameters", "RecipesBase", "RecursiveArrayTools", "SciMLBase", "StaticArraysCore"]
git-tree-sha1 = "c959cfd2657d16beada157a74d52269e8556500e"
uuid = "459566f4-90b8-5000-8ac3-15dfb0a30def"
version = "2.37.0"
version = "3.6.2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why we were on 2.37.0 - that was February 14 release. looks like many deps got updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try locally. It could be brought in by the DiffEqCallbacks update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It happens when I update the environments locally too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll merge it then! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DiffEqCallbacks
now depends on NonlinearSolve
, which brings a bunch of extra dependencies
Purpose
Tag v0.12.4