Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run snow model at all SNOWMIP sites #694

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Run snow model at all SNOWMIP sites #694

merged 1 commit into from
Jul 19, 2024

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jul 10, 2024

Purpose

Run snow model at all SNOWMIP sites

To-do

[X] Add yearly average plot of SWE and T_sfc, along with data (unaveraged)
[X] Use ClimaArtifacts instead of local version
[X] Update buildkite run
[X] Review

Content

Generalized the snow_cdp.jl script to run the snow model at all SNOWMIP sites, not just Col de Porte. Instead of referring to process_cdp.jl to read in the observed site data, snow_cdp.jl now calls process_snowmip.jl to accomplish this. The snow_cdp.jl script takes an argument for the SNOWMIP site that the model will be run on; if no site is given, cdp is used.

Review checklist

I have:

In the Content, I have included

  • relevant unit tests, and integration tests,

  • appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck requested a review from sarahhzhangg July 10, 2024 20:30
@kmdeck kmdeck force-pushed the sz/snow_surface_temp branch from d9e237b to 927a29f Compare July 19, 2024 15:44
@kmdeck kmdeck force-pushed the sz/snow_surface_temp branch from c00d93f to b899d69 Compare July 19, 2024 16:51
@kmdeck kmdeck marked this pull request as ready for review July 19, 2024 16:51
@kmdeck kmdeck enabled auto-merge July 19, 2024 16:51
@kmdeck kmdeck changed the title Sz/snow surface temp Run snow model at all SNOWMIP sites Jul 19, 2024
@kmdeck kmdeck merged commit 93aef40 into main Jul 19, 2024
10 checks passed
@kmdeck kmdeck deleted the sz/snow_surface_temp branch October 10, 2024 21:15
@kmdeck kmdeck restored the sz/snow_surface_temp branch October 10, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants