Kd/rb/ar/basic sif refactor #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisRenchon
force-pushed
the
kd/rb/ar/basic_SIF_refactor
branch
2 times, most recently
from
556c61c to
ca2a544
Compare
Sbozzolo
force-pushed
the
kd/rb/ar/basic_SIF_refactor
branch
from
ca2a544 to
644cb29
Compare
AlexisRenchon
force-pushed
the
kd/rb/ar/basic_SIF_refactor
branch
4 times, most recently
from
b50c9ad to
a2d4381
Compare
For now, adds a simple sif parameterization "Lee2015SIFModel" to AbstractSIFModel. Co-authored-by: AlexisRenchon <a.renchon@gmail.com> Co-authored-by: Sbozzolo <gbozzola@caltech.edu> Co-authored-by: kmdeck <kdeck@caltech.edu> Co-authored-by: braghiere <renato.braghiere@gmail.com>
AlexisRenchon
force-pushed
the
kd/rb/ar/basic_SIF_refactor
branch
from
a2d4381 to
1776018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a simple SIF model,
Lee2015SIFModel, inAbstractSIFModelwithin theCanopymodule.@braghiere as you suggested, we made a new AbstractSIFModel, independent from others components of the Canopy module (where we now have photosynthesis, stomatal conductance, radiative transfer, autotrophic respiration, solar induced fluorescence, etc.). We named this first simple sif model "Lee2015SIFModel", if you have a better name let us know. This implementation allows to easily dispatch on other sif models in the future. Can you check the equations and units? Thanks!