Add support for regional simulations #710
Conversation
Sbozzolo
force-pushed
the
gb/regional
branch
19 times, most recently
from
37b71f3 to
886fd85
Compare
| @@ -1,7 +1,7 @@ | |||
| # # Global bucket run using spatial map albedo | |||
There was a problem hiding this comment.
Should we make a different file for a regional experiment?
Since this file is called "global_ ..."
(or rename this file)
There was a problem hiding this comment.
I renamed this to bucket_era5 because staticmap was misleading
|
Note that PR hardcodes the radius of the Earth in same places, which is not ideal. |
| @@ -184,7 +184,9 @@ end | |||
| A struct holding the necessary information | |||
| to construct a domain, a mesh, a 2d spectral | |||
| element space, and the resulting coordinate field. | |||
| Note that only periodic domains are currently supported. | |||
There was a problem hiding this comment.
I think we need to keep this - because in principle, if we turned on lateral flow, we would be using periodic BC
Alternatively we can state that only independent columns are supported currently (no need for BC in the horizontal)
There was a problem hiding this comment.
(ClimaCore does not support non-periodic BC, I believe, even for boxes)
There was a problem hiding this comment.
I added a note saying that only "no lateral flow is supported"
| "Number of elements to discretize interval, (nx, ny)" | ||
| nelements::Tuple{Int, Int} | ||
| "Flags for periodic boundaries; only true is supported" |
There was a problem hiding this comment.
I added a note saying that only "no lateral flow is supported"
There was a problem hiding this comment.
To avoid the hardcoding of R_earth, my only thought would be that we could adjust Plane as you have it, but instead make a RegionalDomain type (akin to HybridBox, which we would then leave untouched - except with longlat=nothing passed to Plane in the constructor) which takes the same arguments as HybridBox except additional R_earth and longlat
I made |
Sbozzolo
force-pushed
the
gb/regional
branch
2 times, most recently
from
dbb3ab2 to
3e5683d
Compare
[skip ci][ci skip] To be written
Using ClimaUtilities 0.1.11 which should be faster
This PR adds support for regional simulations, box simulations centered around a specific long/lat. Regional simulations are useful for all sorts of reasons, including debugging. Here, I use the fact that there is no later information exchange and set up a box domain.
Closes #709